Add permit functions for flashblocks number contract #287
+309
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
flashblocks-permit
branch
from
6499f4f to
f93045b
Compare
SozinM
reviewed
Oct 6, 2025
avalonche
force-pushed
the
flashtestations-permit
branch
from
75e520c to
ef81cca
Compare
avalonche
force-pushed
the
flashtestations-permit
branch
2 times, most recently
from
e79a2c9 to
9f2874a
Compare
avalonche
force-pushed
the
flashblocks-permit
branch
from
f93045b to
b3c9f33
Compare
avalonche
force-pushed
the
flashblocks-permit
branch
from
b3c9f33 to
8b7e42a
Compare
akundaz
reviewed
Oct 28, 2025
| let tx = match self.estimate_flashblock_number_tx_gas(ctx, &mut evm, signer, nonce) | ||
| { | ||
| Ok(gas_used) => { | ||
| // Due to EIP-150, 63/64 of available gas is forwarded to external calls so need to add a buffer |
There was a problem hiding this comment.
Why don't we need to add the gas buffer anymore?
There was a problem hiding this comment.
this buffer is already calculated in the sign_tx function
SozinM
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
permit calls to flashblocks number contract if flashtestations are enabled as well. default to regular flashblocks number contract if flashtestations are not enabled.
--flashblocks.flashblocks-number-contract-use-permitflag to enable.✅ I have completed the following steps:
make lintmake test